feat: add same_channel() method #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks reasonable! Looks like CI failed, I think some of those tests need feature flags on them. |
the same_channel() is familiar with futures_channel Sender::same_receiver, however flume is a mpmc library, so use the same_receiver or same_sender name may not fit this PR allow users to check two Sender, Receiver, SendSink or RecvStream are belong to the same channel or not, that may be helpful in some cases
Sherlock-Holo
force-pushed
the
same_channel
branch
from
9824485
to
17d25c7
Compare
|
I have set |
|
Thanks! |
|
I've just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the same_channel() is familiar with futures_channel Sender::same_receiver, however flume is a mpmc library, so use the same_receiver or same_sender name may not fit
this PR allow users to check two Sender, Receiver, SendSink or RecvStream are belong to the same channel or not, that may be helpful in some cases